Update CI to pass again; Add annotation for mypy in docs/source/conf.py#178
Merged
bernhardkaindl merged 2 commits intoxenserver:masterfrom Sep 24, 2025
Conversation
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes CI failures by adjusting coverage requirements and adding type annotations for mypy compliance.
- Reduced test coverage requirement from 96% to 95%
- Removed temporary exclusion of
xcp/dmv.pyfrom diff coverage analysis - Added type annotation for
exclude_patternsvariable in Sphinx configuration
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tox.ini | Adjusted coverage thresholds and removed file exclusion to fix CI |
| docs/source/conf.py | Added type annotation for mypy compliance |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This comment was marked as off-topic.
This comment was marked as off-topic.
bernhardkaindl
requested review from
DeliZhangX,
GeraldEV,
ashwin9390,
incipit0,
minglumlu and
rosslagerwall
and removed request for
GeraldEV,
ashwin9390,
chunjiez and
incipit0
rosslagerwall
approved these changes
Sep 23, 2025
DeliZhangX
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update CI to pass again; Add annotation for mypy in docs/source/conf.py
xcp/dmv.pyfrom the diff/patch-coverage analysisA simple PR without product code changes to fix CI and mypy.